Fix the non-running of slow tests in CI #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When I added the feature to skip slow tests in CI under most conditions, I made the classic mistake of using the logical ternary operator pattern A && B || C with B being something that evaluates to boolean false. So the result was always C, i.e. '-m "not slow"', which skips the slow tests. In this commit I'm flipping the sense of the condition so that I can put the truthy value '-m "not slow"' in position B, which makes it work properly. I hate Javascript :-( or more precisely, the miniature Javascript-based logic expressions that Github supports in workflow definitions, along with the lack of strong typing.
sjlongland
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I added the feature to skip slow tests in CI under most conditions, I made the classic mistake of using the logical ternary operator pattern
A && B || CwithBbeing something that evaluates to boolean false. So the result was alwaysC, i.e.'-m "not slow"', which skips the slow tests.In this commit I'm flipping the sense of the condition so that I can put the truthy value
'-m "not slow"'in positionB, which makes it work properly.I tested this with another manually triggered workflow run, and this time it did run the distribution package tests which are normally skipped.
Closes #86