Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setuptools as an explicit dependency #7

Merged
merged 1 commit into from
Jul 4, 2023

Conversation

diazona
Copy link
Owner

@diazona diazona commented Jul 4, 2023

I'm so used to setuptools only being required for building packages that I forgot in this case we actually depend on it directly. So I'm adding it as an explicit runtime dependency.

I'm so used to setuptools only being required for building packages that
I forgot in this case we actually depend on it directly. So I'm adding
it as an explicit runtime dependency.
@diazona diazona added this to the Initial release milestone Jul 4, 2023
@diazona diazona requested a review from sjlongland July 4, 2023 01:15
@sjlongland
Copy link
Collaborator

Ahh yes, common trap… forgetting a dependency.

@sjlongland
Copy link
Collaborator

remote: Resolving deltas: 100% (4/4), completed with 2 local objects.
remote: error: GH006: Protected branch update failed for refs/heads/main.
remote: error: Changes must be made through a pull request.

… Ohh, tricky. So I was trying to do the merge from the git CLI. Protection didn't realise that's what I was doing, and so protectively blocked me.

That said, doing it from the CLI, one must be certain they've got the right branches and that everything is in sync, so lots to get wrong, probably better I get used to doing it through the web interface. :-)

@sjlongland sjlongland merged commit 3fdd259 into main Jul 4, 2023
@sjlongland sjlongland deleted the add-setuptools-dependency/1/dev branch July 4, 2023 08:45
@diazona
Copy link
Owner Author

diazona commented Jul 4, 2023

Ah yeah good point, I hadn't even really thought about that, I just set it up to require merge commits (done through the web UI) out of habit. But I think there is something to be said for forcing certain operations to be done through the website for traceability. One in particular that I did have in mind was forcing releases to be prepared only by CI, not manually. (but that's something to be set up later, of course)

@sjlongland
Copy link
Collaborator

Yeah, no biggie really… historically I've liked to do the merge on the CLI as it's then digitally signed using my key so there's cryptographic proof that I did it and not someone who managed to snatch a Github session token from my browser.

In the scheme of things though, this little detail does not really matter. The probability of this happening is quite small. Call it security paranoia. :-) I think the current set-up will work fine, I've just got to un-train myself from old habits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants