Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support keywords #62

Merged
merged 3 commits into from
Aug 21, 2023
Merged

Support keywords #62

merged 3 commits into from
Aug 21, 2023

Conversation

diazona
Copy link
Owner

@diazona diazona commented Aug 20, 2023

This is pretty straightforward, we just copy the list of keywords from setuptools.

Closes #31

This code does a simple copy of keywords from setuptools. I've made it
so that if the list of keywords is empty, no entry will be added to
pyproject.toml, mostly for consistency with how we handle other fields.
These tests cover the simple cases and some edge cases. I added them to
an existing test file because there wasn't enough there to make it
important to split these tests into their own file.
This commit adds the expected result for the keywords field to
test_everything().

I changed one thing in the input setup.cfg file: the list of keywords
was space-separated, but it should have been comma-separated. In fact
the core metadata specification was changed from using spaces to commas
precisely because that's what distutils and setuptools did.
  https://packaging.python.org/en/latest/specifications/core-metadata/#core-metadata-keywords
@diazona diazona added enhancement New feature or request setuptools-fields Fields in the pyproject data structure that this project needs to support labels Aug 20, 2023
@diazona diazona added this to the Initial release milestone Aug 20, 2023
@diazona diazona requested a review from sjlongland August 20, 2023 05:13
@sjlongland sjlongland merged commit db93cdf into main Aug 21, 2023
@sjlongland sjlongland deleted the keywords/1/dev branch August 21, 2023 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request setuptools-fields Fields in the pyproject data structure that this project needs to support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support keywords
2 participants