Split linting/static checks apart from pytest #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I thought it made sense to have some way to run the static checks (which are normally triggered by pre-commit) through tox, so I added this environment to enable it. It's not a particularly useful thing to have in general though, since people can just run pre-commit directly.
With this commit we will no longer run black, mypy, and ruff from pytest. Since we already run them from pre-commit, and pre-commit runs during CI as well, there's no need to additionally run them from pytest.
|
I enabled auto-merge on this PR for fun, let's see how it works 😛 |
sjlongland
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Static checks are already run by pre-commit, which gets called from CI, so there is very little I had to do to split them out of pytest. I just removed the pytest plugins that enable those checks.
I added a tox environment to allow people to run the static checks through tox in case they don't want to install and run pre-commit directly for some reason.
Closes #39