Configure pre-commit.ci to skip the actionlint-docker hook #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently the runners that pre-commit.ci uses don't have Docker installed, so Docker-based hooks will fail on that platform. Accordingly I'm setting the actionlint-docker hook to be skipped. Technically this allows people to bypass the linting of Github Actions configuration and introduce an invalid workflow, but I don't think we have to worry about that too much. If there are syntax errors in the workflow configuration, Github might catch them, and otherwise someone should notice sooner or later when running pre-commit locally. We could also start using the lite version of pre-commit.ci which runs as a Github Action, and that would allow us to use Docker hooks, but I don't think that's really necessary at this point.
sjlongland
approved these changes
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently the runners that pre-commit.ci uses don't have Docker installed, so Docker-based hooks will fail on that platform. Accordingly I'm setting the
actionlint-dockerhook to be skipped.Technically this allows people to bypass the linting of Github Actions configuration and introduce an invalid workflow, but I don't think we have to worry about that too much. If there are syntax errors in the workflow configuration, Github might catch them, and otherwise someone should notice sooner or later when running
pre-commitlocally.We could also start using the lite version of pre-commit.ci which runs as a Github Action, and that would allow us to use Docker hooks, but I don't think that's really necessary at this point.