Add a pre-commit hook to verify Github Actions configuration #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm using the actionlint-docker pre-commit hook to verify the workflow files. We could use the plain old actionlint hook instead (non-Docker) but I had some trouble compiling it on my machine so I figured this would be easier. If anyone complains about the dependency on Docker then we can adjust it accordingly. This is going to help catch problems that may occur as we update the CI configuration in upcoming commits.
sjlongland
approved these changes
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using the actionlint-docker pre-commit hook to verify the workflow files. We could use the plain old actionlint hook instead (non-Docker) but I had some trouble compiling it on my machine so I figured this would be easier. If anyone complains about the dependency on Docker then we can adjust it accordingly.
This is going to help catch problems that may occur as we update the CI configuration in upcoming commits.
I made this change as part of #23 but it's logically independent and I'm still having problems getting #23 to pass tests, so I figured this should be merged separately.