Split keywords in test support code #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even though the core metadata allows multiple Keywords headers, in practice all a package's keywords seem to be combined into one header joined by commas, or maybe spaces for some older packages. This commit changes the test support code that parses core metadata to account for that by splitting the Keywords header (if single-valued). The delimiter is chosen based on the metadata version: in core metadata version 1.x, it allows spaces as a separator, but in version 2.x, it only allows commas.
sjlongland
approved these changes
Jul 23, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though the core metadata allows multiple Keywords headers, in practice all a package's keywords seem to be combined into one header joined by commas, or maybe spaces for some older packages. This commit changes the test support code that parses core metadata to account for that by splitting the Keywords header (if single-valued). The delimiter is chosen based on the metadata version: in core metadata version 1.x, it allows spaces as a separator, but in version 2.x, it only allows commas.
Closes #136