Parse dependencies with no markers from core metadata #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These new log messages help us get better visibility into what our test support code is doing, which should be useful when tracking down bugs.
In our test support code that parses the core metadata of a package, it turns out I had totally forgotten to parse dependencies which do not have any markers. This commit adds a branch to do that.
Now that our test support code properly handles dependencies with no markers, the dependency-related tests in our external project test suite are passing, so I've removed their xfail markers. Note that one of these xfailures was marked as being related to issue #135, but that's a typo, they are both related to issue #133. Since I'm removing the xfail markers anyway, I didn't bother to fix it before deleting it.
diazona
force-pushed
the
handle-dependencies-without-markers/1/dev
branch
from
aa6b2fa to
7a4eecc
Compare
sjlongland
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our test support code that parses the core metadata of a package, it turns out I had totally forgotten to parse dependencies which do not have any markers. This PR adds a branch to do that and updates the expected test results accordingly. I also added some logging messages which were helpful in diagnosing the problem.