Conditionally disable the pytest distribution package test #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running tests under Python 3.12 with setuptools_scm==3.4.1, we run into a problem where a call to setuptools.setup() tries to load a newer version of setuptools_scm, and that conflicts with the older version that is already in sys.modules. I haven't fully figured out the details, but the gist is that setuptools attempts to read and install the entry point specifications from the newer version of setuptools_scm while using the older version's code, and there is one particular entry point whose value refers to the setuptools_scm._integration module which doesn't exist in the older version's code. This winds up breaking every test that runs after the older version of setuptools_scm gets loaded. We have various options for fixing this, but I don't want to hold up the release any longer while figuring out what the best way to do it is. (I'm guessing that the best approach is just to use virtual environments for distribution package tests, but I want to explore the options.) So I'm disabling the distribution package test which triggers this error when using Python>=3.12 and setuptools_scm<6. We can implement a proper fix later.
diazona
force-pushed
the
disable-pytest-distribution-package-test-py312/1/dev
branch
from
b841af4 to
c4bfd8d
Compare
|
I guess we won't really know if this solves the problem until we try making a release again, which is something to fix for the future, but for now probably best to just go ahead with it. I did run the tests locally and this seems to work, and I'll try making a release candidate before the real release to make sure it works. |
sjlongland
approved these changes
Dec 28, 2023
diazona
deleted the
disable-pytest-distribution-package-test-py312/1/dev
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running tests under Python 3.12 with setuptools_scm==3.4.1, we run into a problem where a call to
setuptools.setup()tries to load a newer version of setuptools_scm, and that conflicts with the older version that is already in sys.modules. I haven't fully figured out the details, but the gist is that setuptools attempts to read and install the entry point specifications from the newer version of setuptools_scm while using the older version's code, and there is one particular entry point whose value refers to the setuptools_scm._integration module which doesn't exist in the older version's code. This winds up breaking every test that runs after the older version of setuptools_scm gets loaded.We have various options for fixing this, but I don't want to hold up the release any longer while figuring out what the best way to do it is. (I'm guessing that the best approach is just to use virtual environments for distribution package tests, but I want to explore the options.) So I'm disabling the distribution package test which triggers this error when using Python>=3.12 and setuptools_scm<6. We can implement a proper fix later.
Note that I omitted a changelog fragment because I don't really want to have to regenerate the changelog just for this, and anyway this PR doesn't fix the issue, it just postpones dealing with the problem.
Related to #145 (but does not close it)