Work around keyword arguments missing in older versions of Python #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The filter keyword to tarfile.TarFile.extract_all() was added in Python 3.8. This change patches the code to work on earlier Python versions as well.
functools.cache() was only introduced in Python 3.9, so for earlier Python versions we should use lru_cache() instead. This commit implements that.
I went through the process of running towncrier locally to generate a changelog fragment, then ran it again to add that fragment into the changelog, and manually combined it with the previous version. This normally shouldn't be necessary, I'm only doing it this time to help recover from a failed release.
sjlongland
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a couple issues in test support code that were affecting older Python versions.
I also deleted a changelog fragment that didn't get deleted previously, for some reason.
Closes #143