Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .editorconfig file for consistency #12

Merged
merged 1 commit into from
Jul 8, 2023
Merged

Conversation

diazona
Copy link
Owner

@diazona diazona commented Jul 6, 2023

The file .editorconfig defines settings that can be used by various text editors, according to the specification at https://editorconfig.org/. I don't use it myself, but if anyone does, the settings there should be consistent with what we've given in the configurations of other linters, so in this commit I'm updating the line length and indentation mode to match usage and configuration in the rest of the project.

The file .editorconfig defines settings that can be used by various text
editors, according to the specification at https://editorconfig.org/. I
don't use it myself, but if anyone does, the settings there should be
consistent with what we've given in the configurations of other linters,
so in this commit I'm updating the line length and indentation mode to
match usage and configuration in the rest of the project.
@diazona diazona added this to the Initial release milestone Jul 6, 2023
@diazona diazona requested a review from sjlongland July 6, 2023 04:14
@diazona diazona assigned diazona and sjlongland and unassigned diazona Jul 6, 2023
@diazona
Copy link
Owner Author

diazona commented Jul 8, 2023

Just checking, did you have any particular reason to approve this and not merge it? I mean, I am totally happy to merge it myself, I just wanted to check since we were doing it differently for previous PRs. (Will it not let you merge it? I guess I don't know what the experience is like from your end so there might be unintended side effects of the configuration changes I made 😅)

@sjlongland
Copy link
Collaborator

Just checking, did you have any particular reason to approve this and not merge it? I mean, I am totally happy to merge it myself, I just wanted to check since we were doing it differently for previous PRs. (Will it not let you merge it? I guess I don't know what the experience is like from your end so there might be unintended side effects of the configuration changes I made sweat_smile)

Ahh whoops, yes… meant to merge it, doing that now. :-)

@sjlongland sjlongland merged commit 5d4bd96 into main Jul 8, 2023
@sjlongland sjlongland deleted the editorconfig/1/dev branch July 8, 2023 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants