add cucumber feature for taking screenshots of important pages #3797
Conversation
|
+1 for pulling such a functionality in, -1 on having the images in git. Lets just write a workflow to use this, like, make your changes, checkout develop, generate images, checkout your branch generate images, compare. |
| @screenshot_path.mkpath unless @screenshot_path.exist? | ||
| end | ||
|
|
||
| def take_screenshot(name, path) |
There was a problem hiding this comment.
I think I'd prefer to specify here if a reference or comparison screenshot is taken, the current behaviour, although it's the DRYer approach, is a bit too much, "you have to know how it works" for my personal taste since ensure_screenshot_location sounds like ensure_screenshot_location_exists to me and less like a setter to me. This does resemble in the actual feature, if you ignore the scenario description, the difference between the two seems totally opaque to me. Maybe incorporate it into the name, so the names would be like reference/stream and current/activity etc.
|
Maybe also add a rake task to generate the actual diffs? :) |
|
ok, I updated the PR. |
|
Amazing, I'd call it good to go, just an advertisement in the changelog would be nice IMO :) |
- for before/after comparisons, including rake tasks for easily generating the images from command line
add cucumber feature for taking screenshots of important pages
dunno, if we even want this in the current form,
but for now at least it's something to think about.
The idea is: we keep 'reference screenshots' and cucumber scenarios to generate them.
everytime a bigger stylesheet change is made, we can generate 'comparison screenshots' and see, if anything changed, that wasn't supposed to.
... not sure we want to keep the reference images in git, though?