misc: removed deployment group validation when deleting CD pipelines #5989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prkhrkat
requested review from
vikramdevtron,
nishant-d and
prakarsh-dt
as code owners
prkhrkat
changed the title
vikramdevtron
approved these changes
Oct 15, 2024
|
prkhrkat
changed the title
github-actions
bot
added
PR:Ready-to-Review
and removed
PR:Issue-verification-failed
labels
iamayushm
added a commit
that referenced
this pull request
Oct 21, 2024
* trigger service import * manual Cd trigger sync * migration point * trigger service code sync * wf runner impl * return chartType * cd WIP * pree deploy sorted * refactor stage one * misc: Replaced != with <> for PostgreSQL compatibility (#5987) * error handling while creating github repo * Replaced != with <> for PostgreSQL compatibility * removed deployment group validation when deleting CD pipelines (#5989) * extracting logic for cd trigger in function (already present on enterprise) * adding extra error * wip: adding back migration code --------- Co-authored-by: nishant <nishant@devtron.ai> Co-authored-by: prakhar katiyar <39842461+prkhrkat@users.noreply.github.com>
vikramdevtron
added a commit
that referenced
this pull request
Oct 24, 2024
* misc: Replaced != with <> for PostgreSQL compatibility (#5987) * error handling while creating github repo * Replaced != with <> for PostgreSQL compatibility * removed deployment group validation when deleting CD pipelines (#5989) * fix for multiple param of filter in helm app list (#6013) * fix: plugin getByName method error handling (#6016) * plugin fix * reverted errnorows change * dep import --------- Co-authored-by: prakhar katiyar <39842461+prkhrkat@users.noreply.github.com> Co-authored-by: kartik-579 <84493919+kartik-579@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #
Checklist:
Does this PR introduce a user-facing change?