-
Notifications
You must be signed in to change notification settings - Fork 671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DC 2016] Replace Capital One logo #326
Conversation
The existing logo is for Capital One Investing; however, our sponsorship is from Capital One corporate, so replacing the logo at their request.
Hello, Event-specific sponsor profiles are frowned upon (see the README); might I suggest modifying this PR such that this sponsor is referred to as "Capital One Corporate"? In practice this would mean |
@@ -0,0 +1,2 @@ | |||
name: "Capital One" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add "Corporate" in here so as to differentiate it from the existing Capital One profile?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I chose to rename the existing capitalone.yml to "Capital One Investing" to match the image, and to leave capitalone-corp.yml (former capitalone-dc.yml) as "Capital One" to match its image and the sponsor's wishes.
I'll change from -DC to -corp when I get to my desk, but my position as well as the sponsor's is that the proper logo was in place before the migration, and unless we're going to break old events that use the Capital One Investing logo, a new profile is needed. And the sponsor wishes to be known simply as "Capital One", not "Capital One corporate."
|
Also, changed the description of capitalone.yml (not -corp) to "Capital One Investing" to match the logo used there. In a perfect world, we would have capitalone.yml and capitaloneinvesting.yml, but hopefully this will do for now.
Seattle was the conflict. It turns out they had asked us to change it as well, and we missed it. In this case they should be standardized on the same logo. |
Hello again! I've spoken with an organiser of the only other event that Capital One are sponsoring, and they want to have the logo changed as well. I will henceforth prepare a PR to replace the extant logo with the one that you've proposed here, thus satisfying both of your use cases neatly. PR incoming. |
Thanks Dan and Ken! |
The existing logo is for Capital One Investing; however, our sponsorship
is from Capital One corporate, so replacing the logo at their request.