Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DC 2016] Replace Capital One logo #326

Closed
wants to merge 2 commits into from

Conversation

mcornick
Copy link
Contributor

The existing logo is for Capital One Investing; however, our sponsorship
is from Capital One corporate, so replacing the logo at their request.

The existing logo is for Capital One Investing; however, our sponsorship
is from Capital One corporate, so replacing the logo at their request.
@phrawzty
Copy link
Collaborator

Hello,

Event-specific sponsor profiles are frowned upon (see the README); might I suggest modifying this PR such that this sponsor is referred to as "Capital One Corporate"? In practice this would mean s/-dc/-corp/; I suppose, but it means that the profile can be used by other events more intuitively.

@@ -0,0 +1,2 @@
name: "Capital One"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add "Corporate" in here so as to differentiate it from the existing Capital One profile?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I chose to rename the existing capitalone.yml to "Capital One Investing" to match the image, and to leave capitalone-corp.yml (former capitalone-dc.yml) as "Capital One" to match its image and the sponsor's wishes.

@mcornick
Copy link
Contributor Author

I'll change from -DC to -corp when I get to my desk, but my position as well as the sponsor's is that the proper logo was in place before the migration, and unless we're going to break old events that use the Capital One Investing logo, a new profile is needed. And the sponsor wishes to be known simply as "Capital One", not "Capital One corporate."

On May 11, 2016, at 10:47 AM, dan phrawzty notifications@github.com wrote:

Hello,

Event-specific sponsor profiles are frowned upon (see the README); might I suggest modifying this PR such that this sponsor is referred to as "Capital One Corporate"? In practice this would mean s/-dc/-corp/; I suppose, but it means that the profile can be used by other events more intuitively.


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub

Also, changed the description of capitalone.yml (not -corp) to "Capital
One Investing" to match the logo used there. In a perfect world, we
would have capitalone.yml and capitaloneinvesting.yml, but hopefully
this will do for now.
@kmugrage
Copy link
Contributor

Seattle was the conflict. It turns out they had asked us to change it as well, and we missed it. In this case they should be standardized on the same logo.

@phrawzty
Copy link
Collaborator

phrawzty commented May 11, 2016

Hello again! I've spoken with an organiser of the only other event that Capital One are sponsoring, and they want to have the logo changed as well. I will henceforth prepare a PR to replace the extant logo with the one that you've proposed here, thus satisfying both of your use cases neatly. PR incoming.

@phrawzty phrawzty closed this May 11, 2016
@mcornick
Copy link
Contributor Author

Thanks Dan and Ken!

@phrawzty phrawzty mentioned this pull request May 11, 2016
@mcornick mcornick deleted the dc-capital-one-logo branch May 11, 2016 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants