Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add review section #26

Merged
merged 2 commits into from
Feb 7, 2023

Conversation

MohitBansal321
Copy link
Contributor

Description

Please include a summary of the change and which issue is fixed. Also include relevant motivation & further context of what the PR is all about. List any dependencies that are required for this change.

Fixes #(Insert Issue Here Without Brackets)
#7

Changes Include

  • New feature ✨ (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
    I run it locally and check on all points which are best for it
    screenshot provide you what changes i do here
  • Test B

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Screenshots (if any)

Screenshot 2023-02-07 121337

(prefer animated gif)

<hr />
<h5 class="subtitle is-5">Reviews</h5>
{% for review in res.reviews %}
<p>"{{review}}"</p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think italicizing it will make the review actually look like a review? Like how we see reviews on products?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is okay for it and you mention me it is above the open link it if any changes need let me know

Copy link
Member

@Bhupesh-V Bhupesh-V left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just make sure to indent the code (using a jinja compatible formatter)

@MohitBansal321
Copy link
Contributor Author

MohitBansal321 commented Feb 7, 2023

Looks good, just make sure to indent the code (using a jinja compatible formatter)

can I do with help of prettier?

@Bhupesh-V
Copy link
Member

Looks good, just make sure to indent the code (using a jinja compatible formatter)

can I do with help of prettier?

I am not sure whether prettier will take in account of jinja templates, try using this maybe? https://github.com/wholroyd/vscode-jinja

@MohitBansal321
Copy link
Contributor Author

Looks good, just make sure to indent the code (using a jinja compatible formatter)

can I do with help of prettier?

I am not sure whether prettier will take in account of jinja templates, try using this maybe? https://github.com/wholroyd/vscode-jinja

This extension adds language colorization support for the Jinja template language to VS Code.
Now check i done format it

@Bhupesh-V Bhupesh-V merged commit a98f999 into developersIndia:main Feb 7, 2023
@Bhupesh-V
Copy link
Member

@all-contributors please add @MohitBansal321 for code

@allcontributors
Copy link
Contributor

@Bhupesh-V

I've put up a pull request to add @MohitBansal321! 🎉

@MohitBansal321 MohitBansal321 deleted the addReviewSection branch February 15, 2023 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants