-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add review section #26
add review section #26
Conversation
templates/resources.html
Outdated
<hr /> | ||
<h5 class="subtitle is-5">Reviews</h5> | ||
{% for review in res.reviews %} | ||
<p>"{{review}}"</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think italicizing it will make the review actually look like a review? Like how we see reviews on products?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is okay for it and you mention me it is above the open link it if any changes need let me know
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just make sure to indent the code (using a jinja compatible formatter)
can I do with help of prettier? |
I am not sure whether prettier will take in account of jinja templates, try using this maybe? https://github.com/wholroyd/vscode-jinja |
This extension adds language colorization support for the Jinja template language to VS Code. |
@all-contributors please add @MohitBansal321 for code |
I've put up a pull request to add @MohitBansal321! 🎉 |
Description
Please include a summary of the change and which issue is fixed. Also include relevant motivation & further context of what the PR is all about. List any dependencies that are required for this change.
Fixes #(Insert Issue Here Without Brackets)
#7
Changes Include
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
I run it locally and check on all points which are best for it
screenshot provide you what changes i do here
Checklist
Screenshots (if any)
(prefer animated gif)