Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Footer Styling to stick it to the bottom #14

Merged
merged 5 commits into from Feb 7, 2023
Merged

Fixed Footer Styling to stick it to the bottom #14

merged 5 commits into from Feb 7, 2023

Conversation

ghost
Copy link

@ghost ghost commented Feb 6, 2023 •
edited by Bhupesh-V
Loading

Description

Fixed Footer Styling to stick it to the bottom

Fixes #12

Changes Include

  • Bug fix 🐛 (non-breaking change which fixes an issue)
  • New feature ✨ (non-breaking change which adds functionality)
  • Breaking change 😢 (fix or feature that would cause existing functionality to not work as expected)
  • Refactor ⚒️ (code change that neither fixes a bug nor adds a feature)
  • Tooling ⚙️ (Changes to the build process or auxiliary tools and libraries such as documentation generation)
  • Performance ⚡ (code change that improves performance)
  • This change requires a documentation update 📖

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Screenshots (if any)

image

(prefer animated gif)

Bhupesh-V
Bhupesh-V requested changes Feb 6, 2023
View reviewed changes
Copy link
Member

@Bhupesh-V Bhupesh-V left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging this will introduce a bug where the footer overrides some content on the page. Can you address this, maybe?

Screenshot 2023-02-06 at 7 58 36 PM

Screenshot 2023-02-06 at 7 58 36 PM

@Bhupesh-V Bhupesh-V mentioned this pull request Feb 6, 2023
Closed
@ghost
Copy link
Author

ghost commented Feb 6, 2023

Yeah! I'll try to fix it

Made necessary changes to make footer stick to bottom and also making…
27a7bdf 
… sure that it is not overlapping the content
@ghost
Copy link
Author

ghost commented Feb 6, 2023

I think we can make the container class

@ghost ghost closed this Feb 6, 2023
@ghost ghost reopened this Feb 6, 2023
@ghost
Copy link
Author

ghost commented Feb 6, 2023

I think now it is perfect and flawless I tried it with some static content. Now the stuff sticks to bottom without overlapping.

@Bhupesh-V
Copy link
Member

I think now it is perfect and flawless I tried it with some static content. Now the stuff sticks to bottom without overlapping.

It's still the same, did you try to run the app locally? Adding static content might not help test the fix. Please use github codespaces to run the project (follow installation instructions in readme)

Please provide screenshots if possible!

@ghost
Copy link
Author

ghost commented Feb 7, 2023

image

image

Tell me if this is good now. I think now it is perfect.

@ghost
Copy link
Author

ghost commented Feb 7, 2023

image

@siduck
Copy link

siduck commented Feb 7, 2023 •
edited
Loading

image

I think it would look better if the footer had top margin ( 5 rem )

@ghost
Copy link
Author

ghost commented Feb 7, 2023

Yes will add that.

@Bhupesh-V
Copy link
Member

@ansid0102 Yes, it looks good now 👍🏽
Thanks for the feedback @siduck

I think we are good to go 🚀

@Bhupesh-V Bhupesh-V merged commit a9bc191 into developersIndia:main Feb 7, 2023
@Bhupesh-V
Copy link
Member

@all-contributors please add @ansid0102 for code

@allcontributors allcontributors bot mentioned this pull request Feb 7, 2023
Merged
@allcontributors
Copy link
Contributor

@Bhupesh-V

I've put up a pull request to add @ansid0102! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Footer not sticking to bottom
2 participants
@Bhupesh-V @siduck