Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spelling #523

Merged
merged 1 commit into from
Aug 30, 2020
Merged

Fix spelling #523

merged 1 commit into from
Aug 30, 2020

Conversation

AxiosLeo
Copy link
Contributor

Description

Fix spelling of _bootstrap_select_libraries variable

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@bast
Copy link
Member

bast commented Aug 26, 2020

Thank you! Sorry for slow follow-up ... we need to reanimate the automated testing which will be few days of work. But your change is so "obvious" that we might merge it across the CI.

Copy link
Member

@bast bast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just grepped the project. Good catch! I see no reason not to merge. Thank you!

@bast
Copy link
Member

bast commented Aug 26, 2020

Can you please do this step and then I can merge? https://github.com/dev-cafe/cmake-cookbook/pull/523/checks?check_run_id=1006564817

Thank you! Sorry for this extra step.

Fix spelling of `_bootstrap_select_libraries` variable

Signed-off-by: Axios <13862149+AxiosCros@users.noreply.github.com>
@AxiosLeo
Copy link
Contributor Author

Can you please do this step and then I can merge? https://github.com/dev-cafe/cmake-cookbook/pull/523/checks?check_run_id=1006564817

Thank you! Sorry for this extra step.

ok. already done.

@bast
Copy link
Member

bast commented Aug 30, 2020

Thank you!

@bast bast merged commit e2cdfb3 into dev-cafe:master Aug 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants