Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AUTHORS.md and .mailmap #501

Merged
merged 1 commit into from
Sep 23, 2018
Merged

Add AUTHORS.md and .mailmap #501

merged 1 commit into from
Sep 23, 2018

Conversation

robertodr
Copy link
Collaborator

Does what it says on the tin. The list in AUTHORS.md was generated using git shortlog -sn, so authors are ordered by number of commits. Which also happens to be alphabetic order on surnames!

Status

  • Ready to go

Copy link
Member

@bast bast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will send in a correction to the mailmap since this repo does not contain any of my older email addresses.

.mailmap Outdated
Radovan Bast <radovan.bast@gmail.com> <radovan.bast@uit.no>
Radovan Bast <radovan.bast@gmail.com> <rbast@users.noreply.github.com>
Roberto Di Remigio <roberto.diremigio@gmail.com> <roberto.d.remigio@uit.no>
Eric Noulard <eric.noulard@gmail.com> <enoulard@antidot.net>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Patchwork mail address is strange.
It would be better to have only my gmail address.

@bast
Copy link
Member

bast commented Sep 23, 2018

I am a bit concerned about email harversters, and suggest to leave the .mailmap opt-in so that people can add themselves. For me it is not needed since all my commits are bast@users.noreply.github.com which github recognizes.

@robertodr
Copy link
Collaborator Author

We can have it opt-in, sure. I generated this one looking at the log. I'll only keep bast@users.noreply.github.com for @bast and GMail for @TheErk What do you think?

@bast
Copy link
Member

bast commented Sep 23, 2018

Thanks! From my perspective this would be great. Thank you.

Copy link
Member

@bast bast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Good for me. Also for you, Eric?

@TheErk
Copy link
Collaborator

TheErk commented Sep 23, 2018

Good for me too.

@bast bast merged commit 387931a into dev-cafe:master Sep 23, 2018
@robertodr robertodr deleted the authors-md branch September 23, 2018 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants