Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix drag and drop by addressing breaking Electron change #19473

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Fix drag and drop by addressing breaking Electron change #19473

merged 1 commit into from
Oct 30, 2024

Conversation

niik
Copy link
Member

@niik niik commented Oct 30, 2024

Description

I noticed that I couldn't drag and drop a folder on top of my development Desktop instance any more. Turns out Electron 32 removed the file.path property from dropped file entries: https://www.electronjs.org/docs/latest/breaking-changes#removed-filepath.

Screenshots

Release notes

Notes:

tidy-dev
tidy-dev approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@tidy-dev tidy-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Works as expected. :)

@niik niik merged commit efb4444 into development Oct 30, 2024
8 checks passed
@niik niik deleted the drop-me-pls branch October 30, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tidy-dev tidy-dev tidy-dev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@niik @tidy-dev