Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide title bar resize handles when maximized #1659

Merged
merged 1 commit into from
May 20, 2017
Merged

Hide title bar resize handles when maximized #1659

merged 1 commit into from
May 20, 2017

Conversation

xt0rted
Copy link
Contributor

@xt0rted xt0rted commented May 20, 2017

This hides the resize handles when the window is maximized so you're able to double click in the ~3px area at the top of the title bar to restore the window size.

Closes #1655

@xt0rted
Copy link
Contributor Author

xt0rted commented May 20, 2017

While getting setup to do this I ran into some issues that I documented in the original issue. Should any of those things be added to setup.md as part of this PR?

@rlabrecque
Copy link

I'd make a new issue for the setup issues. I ran into some of those as well.

@shiftkey
Copy link
Member

Should any of those things be added to setup.md as part of this PR?

@xt0rted just open a separate PR so we can discuss those changes in parallel with this.

Copy link
Member

@niik niik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work @xt0rted, thank you!

@niik niik merged commit f3a38ca into desktop:master May 20, 2017
@CrazyKingJonD
Copy link

@xt0rted xt0rted deleted the issue-1655 branch May 21, 2017 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants