More autocompletion accessibility fixes #16526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This hopefully fixes a glitch with NVDA which doesn't read the aria-live content the first time the element is added.
niik
requested changes
Apr 13, 2023
| @@ -207,6 +211,7 @@ export class AuthorInput extends React.Component< | |||
| private renderAuthors() { | |||
| return ( | |||
| <div | |||
| id="added-authors" | |||
| className="added-author-container" | |||
| ref={this.authorContainerRef} | |||
| aria-labelledby="author-input-label" | |||
There was a problem hiding this comment.
Wouldn't having a label with for mean that this is redundant?
There was a problem hiding this comment.
You would think so, but VoiceOver didn't read it, and I couldn't set a label without its for or otherwise we get a linter error 😞
niik
approved these changes
Apr 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/github/accessibility-audits/issues/3287
Closes https://github.com/github/accessibility-audits/issues/3246
Closes https://github.com/github/accessibility-audits/issues/3244
Description
This work is a follow up of #16335 to address some accessibility issues that were reported after the PR was merged:
Co-Authorslabel right before the input should be alabelelement instead of adiv.Release notes
Notes: [Fixed] NVDA reads number of suggestions when an autocompletion list shows up