Add description for changes list header checkbox #16457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niik
previously approved these changes
Apr 5, 2023
Co-authored-by: Markus Olsson <j.markus.olsson@gmail.com>
Co-authored-by: Markus Olsson <j.markus.olsson@gmail.com>
niik
previously approved these changes
Apr 5, 2023
niik
approved these changes
Apr 5, 2023
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref https://github.com/github/accessibility-audits/issues/3275
Description
Adds the tooltip description of the changed file list header/checkbox as an aria-describe by of the check all box so that it is also screen reader announced. Additionally changed the wording to "included" to match the words used in #16420 to try to better communicate that it is talking about how many files are going to be included in the commit.
Screenshots
CleanShot.2023-04-05.at.09.02.29.mp4
Release notes
Notes: [Improved] Changes list header checkbox tooltip description is announced by screen readers.