Move misattributed popover into view when screen is small and zoomed #16407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tidy-dev
commented
Mar 28, 2023
| @@ -88,6 +88,17 @@ | |||
| bottom: 13px; | |||
|
|
|||
| width: 300px; | |||
|
|
|||
| @media (max-height: 500px) { | |||
| bottom: -125px; | |||
There was a problem hiding this comment.
I considered another approach which would be to change the popover from hardcoded positioning to calculated positioning; but, I didn't think the time involved and testing all the popover use cases would be worth it.
niik
approved these changes
Mar 30, 2023
Abdulaziz سلام |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses https://github.com/github/accessibility-audits/issues/3272
Description
This adds a media query to change misattributed popover positioning when app height/zoom is constrained.
Screenshots
macOS
CleanShot.2023-03-28.at.15.16.15.mp4
windows
CleanShot.2023-03-28.at.15.29.13.mp4
Release notes
Notes: [Improved] Misattributed commit popover does not clip when app is zoomed