Make Preferences Dialog Scroll vertically when zoomed #16317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niik
approved these changes
Mar 16, 2023
There was a problem hiding this comment.
- Could have attempted to add a media query for all dialogs.. but, I was concerned about unintended changes/there maybe some dialog that needs special attention. But.. maybe worth revisiting as I assume this will become a frequent problem in our busier dialogs?
Probably but I'm happy to approve this as-is to unblock us
2. This approach opens up the concern of scrollbars on top of scrollbars for some dialogs. Discussed in the accessibility channel and this seems like this is the lesser of two evils (the other being content being unaccessible). But, totally open to other ideas.
👍 No other great ideas
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/github/accessibility-audits/issues/3265
Description
This makes it so that when at user zooms on Preferences/Options dialog. The content is still navigable.
Considerations for this change:
Screenshots
macOS
CleanShot.2023-03-14.at.14.09.00.mp4
Windows
CleanShot.2023-03-14.at.14.15.25.mp4
Release notes
Notes: [Fixed] The Preferences/Options dialog content is still visible when zoomed.