-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Commit attribution descriptive links #16274
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could this be the kind of thing where we leave the Learn more
text for visual users and use the aria-label
or aria-description
for non-visual users? It feels like they now look super verbose and redundant in the GUI.
The general guidance is to go for more descriptive first. Imho, that is generally just good practice for usability, but also accessibility. However, if size constraints are of concern then using In these cases, I can see in the Misattributed warnings since we are trying to make them be less obtrusive to use them there. But in the repository settings, we already had the full sentence on one of them, all I did was extend the link tags. Thus, feel like keeping them where we have larger real estate makes sense. Another alternative for the misattributed commits warning was to do like:
^ only concern there was that the "learn more" make it clear that you are likely going to some documentation. Thoughts? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer using the Learn more
verbiage, and the last changes you made look good to me!!
Closes https://github.com/github/accessibility-audits/issues/3270, https://github.com/github/accessibility-audits/issues/3264
Description
This updates all our "Learn more" links to be more descriptive for screen reader users.
Screenshots
Release notes
Notes: [Improved] Learn more links are descriptive for screen readers.