Don't check for updates if there's one ready #15275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tidy-dev
approved these changes
Sep 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With staggered releases, we're starting to see some crashes from people who:
Restart noworQuit and Install Updatebuttons.While looking into this, I ran into an old code introduced in #2381 that disabled checking for updates when an update was already downloaded and ready to install, but only on Windows. Instead of doing anything different, we'll do the same on macOS. That way, users who have already downloaded an update will be able to, at least, upgrade to that version, even if newer ones are disabled.
Release notes
Notes: [Fixed] Fix crash installing updates that were downloaded a long time ago on macOS