Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(jsonc): align additional error messages #5799

Merged
merged 3 commits into from
Aug 24, 2024

Conversation

irbull
Copy link
Contributor

@irbull irbull commented Aug 23, 2024

Aligns the error messages in the jsonc folder to match the style guide.

#5574

Aligns the error messages in the `jsonc` folder to match the style
guide.

denoland#5574
@irbull irbull requested a review from kt3k as a code owner August 23, 2024 20:03
@github-actions github-actions bot added the jsonc label Aug 23, 2024
Copy link

codecov bot commented Aug 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.23%. Comparing base (95d7b43) to head (8d53ab0).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5799      +/-   ##
==========================================
+ Coverage   96.22%   96.23%   +0.01%     
==========================================
  Files         481      480       -1     
  Lines       38766    38746      -20     
  Branches     5616     5617       +1     
==========================================
- Hits        37303    37289      -14     
+ Misses       1422     1416       -6     
  Partials       41       41              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

jsonc/parse.ts Outdated Show resolved Hide resolved
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kt3k kt3k merged commit 4ff73ff into denoland:main Aug 24, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants