Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: document design decision to only use @std/assert within testing code #5516

Merged
merged 1 commit into from
Jul 23, 2024
Merged

chore: document design decision to only use @std/assert within testing code #5516

merged 1 commit into from
Jul 23, 2024

Conversation

iuioiua
Copy link
Contributor

@iuioiua iuioiua commented Jul 23, 2024

Closes #4865

@iuioiua iuioiua requested a review from kt3k as a code owner July 23, 2024 02:22
@iuioiua iuioiua enabled auto-merge (squash) July 23, 2024 02:22
@codecov Codecov
Copy link

codecov bot commented Jul 23, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.30%. Comparing base (5cff014) to head (b6eaf5d).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5516   +/-   ##
=======================================
  Coverage   96.30%   96.30%           
=======================================
  Files         465      465           
  Lines       37760    37760           
  Branches     5574     5574           
=======================================
  Hits        36364    36364           
  Misses       1354     1354           
  Partials       42       42

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

kt3k
kt3k approved these changes Jul 23, 2024
View reviewed changes
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iuioiua iuioiua merged commit f1ee8ac into main Jul 23, 2024
16 checks passed
@iuioiua iuioiua deleted the impl-assert-doc branch July 23, 2024 03:09
@iuioiua iuioiua mentioned this pull request Jul 23, 2024
Closed
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kt3k kt3k kt3k approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

suggestion: don't use std/assert in implementation code
2 participants
@iuioiua @kt3k