BREAKING(csv): make ReadOptions private
#5169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5169 +/- ##
==========================================
- Coverage 93.34% 93.34% -0.01%
==========================================
Files 470 470
Lines 37941 37939 -2
Branches 5391 5391
==========================================
- Hits 35416 35414 -2
Misses 2482 2482
Partials 43 43 ☔ View full report in Codecov by Sentry. |
iuioiua
changed the title
ReadOptions private
iuioiua
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ReadOptionsare options for a private functionparseRecord. It doesn't make sense for this type to be exposed as a public API.towards #5159