Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BREAKING(http): rename verifyCookie() to verifySignedCookie() #5138

Merged
merged 2 commits into from
Jun 25, 2024
Merged

BREAKING(http): rename verifyCookie() to verifySignedCookie() #5138

merged 2 commits into from
Jun 25, 2024

Conversation

iuioiua
Copy link
Contributor

@iuioiua iuioiua commented Jun 25, 2024 •
edited
Loading

What's changed

verifyCookie() has been renamed to verifySignedCookie().

Why this change was made

This change was made to make it clear to users that this function only deals with signed cookies.

Migration guide

Use verifySignedCookie() instead of verifyCookie().

- import { verifyCookie } from "@std/http/signed-cookie";
+ import { verifySignedCookie } from "@std/http/signed-cookie";

// ...
- await verifyCookie(signedCookie, key);
+ await verifySignedCookie(signedCookie, key);
// ...

Related

Closes #5134

@github-actions github-actions bot added the http label Jun 25, 2024
@codecov Codecov
Copy link

codecov bot commented Jun 25, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.02%. Comparing base (876c20f) to head (66d3ae0).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5138   +/-   ##
=======================================
  Coverage   93.02%   93.02%           
=======================================
  Files         473      473           
  Lines       38061    38061           
  Branches     5406     5406           
=======================================
  Hits        35405    35405           
  Misses       2605     2605           
  Partials       51       51

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iuioiua iuioiua marked this pull request as ready for review June 25, 2024 10:11
@iuioiua iuioiua requested a review from kt3k as a code owner June 25, 2024 10:11
kt3k
kt3k approved these changes Jun 25, 2024
View reviewed changes
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iuioiua iuioiua merged commit 9ae3547 into main Jun 25, 2024
15 checks passed
@iuioiua iuioiua deleted the http-verify-signed-cookie branch June 25, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kt3k kt3k kt3k approved these changes

Assignees
No one assigned
Labels
http
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

suggestion: rename verifyCookie() to verifySignedCookie() in @std/http/signed-cookie
2 participants
@iuioiua @kt3k