Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: ignore test utils in coverage reporting #5133

Merged

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Jun 25, 2024

This PR unifies the naming convention of test utility files to _test_utils.ts and ignore them from coverage reporting.

Copy link

codecov bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.91%. Comparing base (67eaa4a) to head (094f703).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5133      +/-   ##
==========================================
+ Coverage   92.88%   92.91%   +0.03%     
==========================================
  Files         480      473       -7     
  Lines       38323    38065     -258     
  Branches     5401     5398       -3     
==========================================
- Hits        35597    35369     -228     
+ Misses       2670     2641      -29     
+ Partials       56       55       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice

@kt3k kt3k merged commit 365f989 into denoland:main Jun 25, 2024
15 checks passed
@kt3k kt3k deleted the chore-ignore-test-utils-from-coverage-report branch June 25, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants