Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(cli,encoding,fmt,jsonc,path,semver,testing,text,toml,url): remove "This module is browser compatible" note #4945

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

iuioiua
Copy link
Contributor

@iuioiua iuioiua commented Jun 3, 2024

This is already stated in JSR.

Copy link

codecov bot commented Jun 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.18%. Comparing base (3159031) to head (f9f91a7).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4945   +/-   ##
=======================================
  Coverage   92.18%   92.18%           
=======================================
  Files         487      487           
  Lines       38765    38765           
  Branches     5394     5394           
=======================================
  Hits        35734    35734           
  Misses       2975     2975           
  Partials       56       56           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kt3k
Copy link
Member

kt3k commented Jun 4, 2024

Note: This only removes This module is browser compatible. from the @module jsdoc. The directives for type-checking browser compatibility still remain at the top of each file.

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iuioiua iuioiua merged commit c5ad9d4 into main Jun 4, 2024
12 checks passed
@iuioiua iuioiua deleted the docs-browser-compat branch June 4, 2024 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants