Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: release 2024.05.29 #4883

Merged
merged 2 commits into from
May 29, 2024
Merged

chore: release 2024.05.29 #4883

merged 2 commits into from
May 29, 2024

Conversation

denobot
Copy link
Contributor

@denobot denobot commented May 29, 2024

The following updates are detected:

module from to type
cli 0.224.3 0.224.4 patch
data-structures 0.224.1 0.225.0 minor
encoding 0.224.2 0.224.3 patch
expect 0.224.2 0.224.3 patch
fmt 0.225.1 0.225.2 patch
front-matter 0.224.0 0.224.1 patch
html 0.224.0 0.224.1 patch
http 0.224.1 0.224.2 patch
ini 0.224.0 0.225.0 minor
msgpack 0.224.1 0.224.2 patch
semver 0.224.0 0.224.1 patch
streams 0.224.1 0.224.2 patch
text 0.224.0 0.224.1 patch
ulid 0.224.0 0.224.1 patch
uuid 0.224.2 0.224.3 patch
yaml 0.224.0 0.224.1 patch

Please ensure:

  • Versions in deno.json files are updated correctly
  • Releases.md is updated correctly

The following commits are ignored:


To make edits to this PR:

git fetch upstream release-2024-05-29-09-47-10 && git checkout -b release-2024-05-29-09-47-10 upstream/release-2024-05-29-09-47-10

Copy link

codecov bot commented May 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.92%. Comparing base (7717c29) to head (859c343).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4883      +/-   ##
==========================================
- Coverage   92.36%   91.92%   -0.44%     
==========================================
  Files         488      488              
  Lines       41603    41603              
  Branches     5409     5372      -37     
==========================================
- Hits        38425    38245     -180     
- Misses       3122     3300     +178     
- Partials       56       58       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kt3k kt3k marked this pull request as ready for review May 29, 2024 09:54
@kt3k kt3k requested review from kt3k and crowlKats as code owners May 29, 2024 09:54
@kt3k kt3k merged commit 673c436 into main May 29, 2024
14 checks passed
@kt3k kt3k deleted the release-2024-05-29-09-47-10 branch May 29, 2024 09:56
@iuioiua
Copy link
Contributor

iuioiua commented May 30, 2024

I feel like the following might've justified having a @std/uuid@0.224.3 release:

Maybe nothing we can do now, but how can we do this better next time?

@kt3k
Copy link
Member

kt3k commented May 30, 2024

I feel like the following might've justified having a @std/uuid@0.224.3 release:

What do you mean? @std/uuid@0.224.3 has been released in this release

@iuioiua
Copy link
Contributor

iuioiua commented May 30, 2024

Sorry, I mean't 0.225.0.

@kt3k
Copy link
Member

kt3k commented May 30, 2024

This is intentional because deprecation doesn't break things unlike BREAKING

@iuioiua
Copy link
Contributor

iuioiua commented May 30, 2024

Is it fine to include deprecations and breaking fixes in patch releases?

@kt3k
Copy link
Member

kt3k commented May 30, 2024

deprecation is fine because it basically only changes docs (the user get 'deprecated' message, but the code itself doesn't break)

breaking fixes

I don't think 'breaking fix' is an official term (at least there's no commit tag expressing it).

@iuioiua
Copy link
Contributor

iuioiua commented May 30, 2024

Ok. The reason for including deprecations makes sense.

Your reasoning for including breaking fixes doesn't make sense to me. But on second thought, including them in a patch release is fine because they only break incorrect use of the API, which seems fine to do in a patch release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants