-
Notifications
You must be signed in to change notification settings - Fork 633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: release 2024.05.29 #4883
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4883 +/- ##
==========================================
- Coverage 92.36% 91.92% -0.44%
==========================================
Files 488 488
Lines 41603 41603
Branches 5409 5372 -37
==========================================
- Hits 38425 38245 -180
- Misses 3122 3300 +178
- Partials 56 58 +2 ☔ View full report in Codecov by Sentry. |
I feel like the following might've justified having a
Maybe nothing we can do now, but how can we do this better next time? |
What do you mean? |
Sorry, I mean't 0.225.0. |
This is intentional because |
Is it fine to include deprecations and breaking fixes in patch releases? |
deprecation is fine because it basically only changes docs (the user get 'deprecated' message, but the code itself doesn't break)
I don't think 'breaking fix' is an official term (at least there's no commit tag expressing it). |
Ok. The reason for including deprecations makes sense. Your reasoning for including breaking fixes doesn't make sense to me. But on second thought, including them in a patch release is fine because they only break incorrect use of the API, which seems fine to do in a patch release. |
The following updates are detected:
Please ensure:
The following commits are ignored:
@returns
tag when return type is type assertion (#4873)doc()
(#4866)encoding/mod.ts
(#4824)To make edits to this PR:
git fetch upstream release-2024-05-29-09-47-10 && git checkout -b release-2024-05-29-09-47-10 upstream/release-2024-05-29-09-47-10