Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(csv,encoding,http,json,media-types,uuid): use rfc-editor.org for RFC links #4777

Merged
merged 4 commits into from
May 20, 2024

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented May 20, 2024

www.rfc-editor.org seems the most official place for hosting RFCs. I think we should always use www.rfc-editor.org urls for the references of RFCs

ref:

Copy link

codecov bot commented May 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.89%. Comparing base (c6a5622) to head (9c8dcd5).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4777   +/-   ##
=======================================
  Coverage   91.89%   91.89%           
=======================================
  Files         485      485           
  Lines       41314    41314           
  Branches     5319     5319           
=======================================
  Hits        37965    37965           
  Misses       3292     3292           
  Partials       57       57           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kt3k kt3k requested a review from iuioiua May 20, 2024 06:16
@iuioiua iuioiua changed the title docs(media-types): use rfc-editor.org for rfc links docs(media-types): use rfc-editor.org for RFC links May 20, 2024
@iuioiua iuioiua changed the title docs(media-types): use rfc-editor.org for RFC links docs(csv,encoding,http,json,media-types,uuid): use rfc-editor.org for RFC links May 20, 2024
Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added more cases. I suggest checking the codebase once more for the remaining old URLs. LGTM and good idea.

@kt3k kt3k merged commit 7228442 into denoland:main May 20, 2024
12 checks passed
@kt3k kt3k deleted the docs-media-types-align-rfc-links branch May 20, 2024 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants