Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: ARCHITECTURE.md #4559

Merged
merged 2 commits into from
Apr 10, 2024
Merged

docs: ARCHITECTURE.md #4559

merged 2 commits into from
Apr 10, 2024

Conversation

iuioiua
Copy link
Contributor

@iuioiua iuioiua commented Apr 9, 2024

First pass.

Closes #4542

@iuioiua iuioiua requested a review from kt3k as a code owner April 9, 2024 05:31
@iuioiua iuioiua requested review from bartlomieju and removed request for kt3k April 9, 2024 05:31
@iuioiua iuioiua requested a review from kt3k April 9, 2024 05:35
kt3k
kt3k approved these changes Apr 10, 2024
View reviewed changes
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iuioiua iuioiua merged commit 31c7786 into main Apr 10, 2024
11 checks passed
@iuioiua iuioiua deleted the architecture-3 branch April 10, 2024 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kt3k kt3k kt3k approved these changes

@bartlomieju bartlomieju Awaiting requested review from bartlomieju

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

proposal: ARCHITECTURE.md
2 participants
@iuioiua @kt3k