Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(semver): align removal version of reverseSort to others #4334

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Feb 15, 2024

This PR suggests to move the removal version of reverseSort to after 0.217.0 to align it to other items (By this change, the users are exposed to the breaking changes less often. That will cause less frictions to the existing users of semver)

@kt3k kt3k requested a review from iuioiua February 15, 2024 07:19
Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we do the same with Comparator.semver?

@kt3k
Copy link
Member Author

kt3k commented Feb 16, 2024

Should we do the same with Comparator.semver?

Thanks for catching it. Yes, we should. I'll send another PR

@kt3k kt3k merged commit 44998e5 into denoland:main Feb 16, 2024
12 checks passed
@kt3k kt3k deleted the align-breaking-version branch February 16, 2024 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants