Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecation(semver): deprecate Comparator functions #4131

Merged
merged 4 commits into from
Jan 9, 2024
Merged

deprecation(semver): deprecate Comparator functions #4131

merged 4 commits into from
Jan 9, 2024

Conversation

timreichen
Copy link
Contributor

ref: #4047

This PR deprecates all public Comparator functions.

Note: Some of these functions are used in range functions, which means they should be made private (for example is_comparator.ts -> _is_comparator.ts) after the deprecation deadline or combined into one _comparator.ts file.

@timreichen timreichen requested a review from kt3k as a code owner January 8, 2024 10:06
@github-actions github-actions bot added the semver label Jan 8, 2024
kt3k
kt3k reviewed Jan 8, 2024
View reviewed changes
semver/comparator_format.ts Outdated Show resolved Hide resolved
@kt3k
Copy link
Member

kt3k commented Jan 8, 2024

in 0.213.0 looks too short notice. (The users only see the deprecation in 0.212.0)

timreichen and others added 2 commits January 8, 2024 12:12
@timreichen @kt3k
Update semver/comparator_format.ts
5aca028 
Co-authored-by: Yoshiya Hinosawa <stibium121@gmail.com>
@timreichen
bump deprecation note
5e57b56
@timreichen
Copy link
Contributor Author

in 0.213.0 looks too short notice. (The users only see the deprecation in 0.212.0)

True, I bumped the note to 0.214.0

@iuioiua iuioiua mentioned this pull request Jan 8, 2024
Closed
iuioiua
iuioiua approved these changes Jan 8, 2024
View reviewed changes
Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

One thing I like to do when doing these deprecation PRs is to do a dry run of the removal. I.e. remove the proposed functions locally and ensure they don't have any unintended side effects in other parts of the API.

kt3k
kt3k approved these changes Jan 9, 2024
View reviewed changes
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iuioiua iuioiua merged commit 4df9f27 into denoland:main Jan 9, 2024
12 checks passed
@iuioiua iuioiua mentioned this pull request Jan 9, 2024
Closed
@timreichen timreichen deleted the semver_deprecate_comparator branch January 9, 2024 13:16
@iuioiua iuioiua mentioned this pull request Feb 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iuioiua iuioiua iuioiua approved these changes

@kt3k kt3k kt3k approved these changes

Assignees
No one assigned
Labels
semver
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@timreichen @kt3k @iuioiua