refactor(semver): make outside() more readable
#4095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iuioiua
reviewed
Jan 4, 2024
There was a problem hiding this comment.
Are you able to add the test case mentioned in #3948 (comment) ?
Done. |
iuioiua
reviewed
Jan 4, 2024
|
Actually, would it make sense to additionally deprecate |
iuioiua
approved these changes
Jan 8, 2024
There was a problem hiding this comment.
LGTM, as this removes the dependency on outside(), which might be worth deprecating.
Please see the comment on the new test that I've added. We should relocate, then tweak this test if the reported behaviour is agreed upon to be a bug (which both Tim and I already do).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
outside()more readable by replacing the algorithm with already existing functions.As pointed out in #3948 (comment), this seems now to be a weird function to include in the semver mod.