Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update versions.json URL in README.md #3945

Merged
merged 2 commits into from
Dec 14, 2023
Merged

docs: update versions.json URL in README.md #3945

merged 2 commits into from
Dec 14, 2023

Conversation

yoshixmk
Copy link
Contributor

Correct compatibility of different versions of the Deno Standard Library and the Deno CLI

@yoshixmk yoshixmk requested a review from kt3k as a code owner December 13, 2023 07:46
@CLAassistant
Copy link

CLAassistant commented Dec 13, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@kt3k
Copy link
Member

kt3k commented Dec 13, 2023

Could you run deno fmt? Also could you sign the CLA from the above link?

@iuioiua iuioiua changed the title Update url for std version on README.md docs: update versions.json URL in README.md Dec 13, 2023
@yoshixmk
Copy link
Contributor Author

@kt3k I signed the CLA.
Successfully executed with fmt command, so is there any way to rerun?

iuioiua
iuioiua approved these changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've gone ahead and run deno fmt myself. Now, LGTM. Thank you for your contribution 🙂

@iuioiua iuioiua merged commit 01937cd into denoland:main Dec 14, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iuioiua iuioiua iuioiua approved these changes

@kt3k kt3k Awaiting requested review from kt3k kt3k is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yoshixmk @CLAassistant @kt3k @iuioiua