Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: "Built with deno_std" badge #3797

Merged
merged 5 commits into from
Nov 24, 2023
Merged

docs: "Built with deno_std" badge #3797

merged 5 commits into from
Nov 24, 2023

Conversation

iuioiua
Copy link
Contributor

@iuioiua iuioiua commented Nov 12, 2023 •
edited
Loading

This will be a cool way for devs to let others know their project is built on the Deno Standard Library. Inspired by https://github.com/denoland/fresh#badges

Preview:
Static Badge

@iuioiua iuioiua marked this pull request as ready for review November 12, 2023 23:07
@iuioiua iuioiua requested a review from kt3k as a code owner November 12, 2023 23:07
@iuioiua
Copy link
Contributor Author

iuioiua commented Nov 15, 2023

I discussed this with Yoshiya. The summary of points made:

  • Yoshiya believe the Standard Library is widely used (in most modules). Having a badge may not be of much use.
  • I believe it can be a badge that module authors would be proud to have, signifying that their module is based on quality code.
  • Another suggestion is to change the text to "Built with deno_std". "Built with the Deno Standard Library" may be too long.

Either way, other opinions are welcome on this.

@iuioiua iuioiua changed the title docs: "Built with the Deno Standard Library" badge docs: "Built with deno_std" badge Nov 21, 2023
@iuioiua
Copy link
Contributor Author

iuioiua commented Nov 21, 2023 •
edited
Loading

Another idea: make the badge blue. Green usually signifies CI status or test coverage. The contract between the text and background is greater. It also just looks a little cooler, IMO. Done.

Static Badge

kt3k
kt3k approved these changes Nov 24, 2023
View reviewed changes
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's land and see the community reactions

LGTM

@iuioiua iuioiua merged commit 259fded into main Nov 24, 2023
11 checks passed
@iuioiua iuioiua deleted the badge branch November 24, 2023 02:54
realpha pushed a commit to realpha/deno_std that referenced this pull request Nov 24, 2023
@iuioiua @realpha
docs: "Built with deno_std" badge (denoland#3797)
4559bbf 
* docs: "Built with the Deno Standard Library" badge

* tweaks

* tweaks

* fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kt3k kt3k kt3k approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iuioiua @kt3k