Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use Array.fromAsync() where possible #3788

Merged
merged 3 commits into from
Nov 10, 2023
Merged

chore: use Array.fromAsync() where possible #3788

merged 3 commits into from
Nov 10, 2023

Conversation

iuioiua
Copy link
Contributor

@iuioiua iuioiua commented Nov 10, 2023

Closes #3767

@iuioiua iuioiua requested a review from bartlomieju November 10, 2023 05:14
@iuioiua iuioiua marked this pull request as ready for review November 10, 2023 05:14
bartlomieju
bartlomieju approved these changes Nov 10, 2023
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice cleanup 👍

@iuioiua iuioiua merged commit 56e2bc1 into main Nov 10, 2023
11 checks passed
@iuioiua iuioiua deleted the array-from-async-cleanup branch November 10, 2023 19:00
@kt3k
Copy link
Member

kt3k commented Nov 11, 2023

FYI Array.fromAsync is currently not available in Chrome https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/fromAsync

This might change the browser compatibility

@iuioiua
Copy link
Contributor Author

iuioiua commented Nov 11, 2023

Ah, good point. I'll review the changes when I can.

@kt3k
Copy link
Member

kt3k commented Nov 11, 2023

The usages in test cases should be just fine. The usages in 'browser compatible' modules might be affecting some users (for example when they use them in island component of fresh)

@iuioiua
Copy link
Contributor Author

iuioiua commented Nov 12, 2023

I just checked, and this PR only touches test files. So we're all good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

@kt3k kt3k Awaiting requested review from kt3k kt3k is a code owner

@crowlKats crowlKats Awaiting requested review from crowlKats crowlKats is a code owner

Assignees
No one assigned
Labels
archive async csv fs http json streams
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

suggestion: use Array.fromAsync() and ReadableSteam.from() where possible
3 participants
@iuioiua @kt3k @bartlomieju