Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BREAKING(encoding): remove deprecated binary APIs #3763

Merged
merged 2 commits into from
Nov 10, 2023
Merged

BREAKING(encoding): remove deprecated binary APIs #3763

merged 2 commits into from
Nov 10, 2023

Conversation

iuioiua
Copy link
Contributor

@iuioiua iuioiua commented Nov 1, 2023

No description provided.

@iuioiua iuioiua requested a review from bartlomieju November 9, 2023 20:24
@iuioiua iuioiua marked this pull request as ready for review November 9, 2023 20:26
@iuioiua iuioiua requested a review from kt3k as a code owner November 9, 2023 20:26
bartlomieju
bartlomieju approved these changes Nov 10, 2023
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iuioiua iuioiua merged commit 19957e5 into main Nov 10, 2023
@iuioiua iuioiua deleted the remove-deprecated-encoding-binary branch November 10, 2023 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

@kt3k kt3k Awaiting requested review from kt3k kt3k is a code owner

Assignees
No one assigned
Labels
encoding
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iuioiua @bartlomieju