Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BREAKING(streams): deprecate readableStreamFromIterable #3486

Merged
merged 3 commits into from
Jul 17, 2023
Merged

BREAKING(streams): deprecate readableStreamFromIterable #3486

merged 3 commits into from
Jul 17, 2023

Conversation

lino-levan
Copy link
Contributor

Closes #3484

kt3k
kt3k approved these changes Jul 11, 2023
View reviewed changes
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@kt3k kt3k changed the title chore: deprecate readableStreamFromIterable BREAKING(streams): deprecate readableStreamFromIterable Jul 11, 2023
@kt3k kt3k merged commit c18a701 into denoland:main Jul 17, 2023
@lino-levan lino-levan deleted the chore-deprecate-readablestreamfromiterable branch July 17, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kt3k kt3k kt3k approved these changes

@crowlKats crowlKats Awaiting requested review from crowlKats crowlKats is a code owner

Assignees
No one assigned
Labels
csv json streams
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecate readableStreamFromIterable in favor of ReadableStream.from
2 participants
@lino-levan @kt3k