Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tools): improved web-compatibility checks #3263

Merged
merged 3 commits into from
Mar 18, 2023
Merged

feat(tools): improved web-compatibility checks #3263

merged 3 commits into from
Mar 18, 2023

Conversation

iuioiua
Copy link
Contributor

@iuioiua iuioiua commented Mar 17, 2023 •
edited
Loading

This change:

  1. Adds a new, non-compulsory tool that suggests potentially browser-compatible files.
  2. Adds the browser-compatible comment to over 100 files that should have it.
  3. Makes a few tiny cleanups to test and test:browser tasks.

@iuioiua iuioiua marked this pull request as ready for review March 18, 2023 00:02
@iuioiua iuioiua requested review from kt3k and crowlKats as code owners March 18, 2023 00:02
kt3k
kt3k approved these changes Mar 18, 2023
View reviewed changes
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice work!

Good to know we have much more browser compatible modules.

@kt3k kt3k merged commit cf14c9b into denoland:main Mar 18, 2023
@iuioiua iuioiua deleted the web-browser-compat-2 branch March 18, 2023 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kt3k kt3k kt3k approved these changes

@crowlKats crowlKats Awaiting requested review from crowlKats crowlKats is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iuioiua @kt3k