Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(json): correct examples #3260

Merged
merged 2 commits into from
Mar 17, 2023
Merged

fix(json): correct examples #3260

merged 2 commits into from
Mar 17, 2023

Conversation

iuioiua
Copy link
Contributor

@iuioiua iuioiua commented Mar 17, 2023

Fixes #3259.

@iuioiua iuioiua marked this pull request as ready for review March 17, 2023 03:16
@iuioiua iuioiua changed the title fix(yaml): correct examples fix(json): correct examples Mar 17, 2023
@iuioiua iuioiua requested a review from kt3k as a code owner March 17, 2023 03:45
lino-levan
lino-levan approved these changes Mar 17, 2023
View reviewed changes
Copy link
Contributor

@lino-levan lino-levan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kt3k
kt3k approved these changes Mar 17, 2023
View reviewed changes
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@kt3k kt3k merged commit 6b1d49d into denoland:main Mar 17, 2023
@iuioiua iuioiua deleted the fix-3259 branch March 17, 2023 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lino-levan lino-levan lino-levan approved these changes

@kt3k kt3k kt3k approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

std@0.180.0/json broken links in the examples from the source files
3 participants
@iuioiua @kt3k @lino-levan