Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: new std/webgpu sub-module #3119

Merged
merged 16 commits into from
Dec 12, 2023
Merged

feat: new std/webgpu sub-module #3119

merged 16 commits into from
Dec 12, 2023

Conversation

crowlKats
Copy link
Member

@crowlKats crowlKats commented Jan 16, 2023 •
edited
Loading

Closes #3036

@iuioiua
Copy link
Contributor

iuioiua commented Jul 25, 2023

Is this still something you want to pursue, @crowlKats?

@iuioiua
Copy link
Contributor

iuioiua commented Oct 9, 2023

@crowlKats, do you think we should close this for now since the WebGPU API is currently not supported? We could re-open this and #3036 once support has been re-added.

@crowlKats
Copy link
Member Author

@iuioiua i think webgpu coming back might be quite soon, so don't think it's necessary to close it

@crowlKats crowlKats mentioned this pull request Nov 13, 2023
Merged
@crowlKats crowlKats marked this pull request as ready for review December 11, 2023 01:35
@crowlKats crowlKats requested a review from kt3k as a code owner December 11, 2023 01:35
iuioiua
iuioiua suggested changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with the WebGPU API, but from a layout and structure perspective, mostly LGTM! I think we just missing a couple of pieces of documentation, mostly examples.

webgpu/create_capture.ts Outdated Show resolved Hide resolved
webgpu/create_capture.ts Show resolved Hide resolved
webgpu/describe_texture_format.ts Show resolved Hide resolved
webgpu/row_padding.ts Show resolved Hide resolved
webgpu/row_padding.ts Show resolved Hide resolved
webgpu/texture_with_data.ts Show resolved Hide resolved
@iuioiua iuioiua changed the title feat: add webgpu folder feat: new std/webgpu sub-module Dec 11, 2023
iuioiua
iuioiua reviewed Dec 11, 2023
View reviewed changes
test.ts Outdated Show resolved Hide resolved
iuioiua
iuioiua suggested changes Dec 11, 2023
View reviewed changes
webgpu/mod.ts Outdated Show resolved Hide resolved
crowlKats and others added 2 commits December 11, 2023 03:49
@crowlKats
remove debug
cb929cc
@crowlKats @iuioiua
Update webgpu/mod.ts
1d5b700 
Co-authored-by: Asher Gomez <ashersaupingomez@gmail.com>
iuioiua
iuioiua approved these changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Niiiice. We should request review from someone who better knows the WebGPU API too.

@crowlKats
Copy link
Member Author

@iuioiua there is no one in the core team like that 😅

@iuioiua
Copy link
Contributor

iuioiua commented Dec 11, 2023

Reviews from contributors are also welcome!

@iuioiua
Copy link
Contributor

iuioiua commented Dec 11, 2023

Note to maintainers: only merge this right before the next release. CI will remain in a failed state until the next runtime release.

@kt3k kt3k mentioned this pull request Dec 11, 2023
Merged
@kt3k
Copy link
Member

kt3k commented Dec 11, 2023

Note to maintainers: only merge this right before the next release. CI will remain in a failed state until the next runtime release.

This is very tricky. The current release flow doesn't allow such thing because the next version of std needs to be released before the next version of CLI.

If we'd prefer to release this for the next version, maybe we should disable stable CI for a moment?

@load1n9
Copy link

load1n9 commented Dec 11, 2023

LGTM nothing really needs to be changed atm

@crowlKats
Copy link
Member Author

Thanks for reviewing @load1n9

@iuioiua iuioiua mentioned this pull request Dec 11, 2023
Merged
@iuioiua
Copy link
Contributor

iuioiua commented Dec 12, 2023

PTAL @kt3k

kt3k
kt3k approved these changes Dec 12, 2023
View reviewed changes
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@iuioiua iuioiua merged commit cd7cbb2 into denoland:main Dec 12, 2023
9 checks passed
@crowlKats crowlKats deleted the webgpu branch December 12, 2023 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iuioiua iuioiua iuioiua approved these changes

@kt3k kt3k kt3k approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add webgpu folder for various WebGPU related utilities
4 participants
@crowlKats @iuioiua @kt3k @load1n9