refactor: use _util/asserts.ts for non-test code
#2857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iuioiua
changed the title
_util/asserts.ts is used for non-test code_util/asserts.ts for non-test code
kt3k
reviewed
Nov 9, 2022
kt3k
reviewed
Nov 9, 2022
kt3k
reviewed
Nov 9, 2022
|
I think what we actually need in |
|
Thanks for the good suggestions! I've made the changes, except for moving I've redone my initial comment on this PR to reflect the new changes. |
kt3k
reviewed
Nov 10, 2022
Comment on lines
+115
to
+118
| All internal non-test code, that is files that do not have `test` or `bench` in | ||
| the name, must use the assertion functions within `_utils/asserts.ts` and not | ||
| `testing/asserts.ts`. This is to create a separation of concerns between | ||
| internal and testing assertions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
_util/assert.tsto_util/asserts.ts.unreachableassertion to_util/asserts.ts, along with corresponding test in_util/asserts_test.ts.testing/asserts.tsto use_util/asserts.ts._util/assert.tsand the "Contributing" section of the repo readme.This is half of what was discussed in #2849. I'll create a tool to enforce the rule after this PR lands.