-
Notifications
You must be signed in to change notification settings - Fork 634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cleanup (collections): Clean up examples, types and file structure #1116
Conversation
@LionC Thank you for the clean-ups! I mostly agree with these changes, but I'm not in favor of moving test files into their own folder. Other std modules put the test files next to the implementation, and in my view that flat structure is easier for the collaborators to work with because the corresponding implementations and tests are close to each other. |
The only problem I see with the current structure is that we explicitly allow I work on the module a lot right now, and even I have a hard time to reorientate myself at a glance when opening the folder, there is just a lot of files with similiar names directly next to each other, some being tests and some being implementations without a consistent ordering pattern (because of the default alphabetical sorting everywhere). My opinion on this is not super strong, but I can say that working on the module and scanning the folders at a glance is already a lot nicer after moving the test files. I will leave final judgement to you and the others though :-) |
Test module next to the module being has been the way since the start and is the convention everywhere else so let's not randomly break from that for |
Done, please re-review @kt3k |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@LionC Thanks! LGTM
This does several tedious clean up tasks in the
collections
module:ts
tag for markdown codeassertEquals
instead ofconsole.assert
to have actually working examplesquite crowded
Predicate
andSelector
read nicely, their meaningis not immediately clear and LSP hovers do not show their content. The types in the module are
mostly straightforward anyways