BREAKING(testing): Renaming assertThrowsAsync to assertRejects #1101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caspervonb
reviewed
Aug 5, 2021
There was a problem hiding this comment.
You'd have to apply this to all modules in the entire std library for the tests to pass.
But this hasn't been discussed yet, as you can see in the unlabelled issue you linked.
Probably the way we'd want to go forward is to keep exporting the old alias with deprecated annotations for a couple of releases as this is used a lot on the wild, including in CLI unit tests.
bartlomieju
requested changes
Aug 6, 2021
bartlomieju
approved these changes
Aug 8, 2021
caspervonb
approved these changes
Aug 9, 2021
|
@getspooky Thank you for your contribution! @caspervonb Thank you for the original suggestion! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The name
assertThrowsAsyncis overly long and verbose, yet it doesn't describe what it actually asserts which is that a promise rejects. RenameassertThrowsAsync->assertRejects.Please see: #1073