Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding header pages for side nav and making headers links #934

Merged
merged 25 commits into from
Oct 7, 2024

Conversation

thisisjofrank
Copy link
Collaborator

@thisisjofrank thisisjofrank commented Oct 3, 2024

  • The 'section headers' in the sidebar for /runtime/ now are links to their respective 'section index page'

  • Each section has a 'section index page' that explains the content in that section

  • Breadcrumbs updated to include sections and link to section index page

  • Breadcrumbs updated to link to subsection index pages for CLI ref and Tutorials

  • Breadcrumb styles slightly tweaked to make text smaller
    Old:
    image

New:
image

  • Breadcrumb arrows moved into li elements so as not to have invalid html

Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Broadly I'm concerned about maintaining these index pages. I guess it's good to have something to click on, but it also means we're going to have to maintain the ToC and these index pages independently.

specific comments below...

deno.lock Outdated Show resolved Hide resolved
runtime/reference/index.md Outdated Show resolved Hide resolved
runtime/reference/index.md Outdated Show resolved Hide resolved
runtime/reference/index.md Outdated Show resolved Hide resolved
runtime/reference/index.md Outdated Show resolved Hide resolved
runtime/reference/cli/index.md Outdated Show resolved Hide resolved
@thisisjofrank thisisjofrank merged commit ba365a0 into main Oct 7, 2024
4 checks passed
@thisisjofrank thisisjofrank deleted the sidenav-headers branch October 7, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants