-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding header pages for side nav and making headers links #934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thisisjofrank
requested review from
donjo,
ry,
marvinhagemeister and
crowlKats
October 3, 2024 20:08
ry
reviewed
Oct 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Broadly I'm concerned about maintaining these index pages. I guess it's good to have something to click on, but it also means we're going to have to maintain the ToC and these index pages independently.
specific comments below...
thisisjofrank
commented
Oct 4, 2024
thisisjofrank
commented
Oct 4, 2024
thisisjofrank
commented
Oct 4, 2024
marvinhagemeister
approved these changes
Oct 4, 2024
crowlKats
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'section headers' in the sidebar for /runtime/ now are links to their respective 'section index page'
Each section has a 'section index page' that explains the content in that section
Breadcrumbs updated to include sections and link to section index page
Breadcrumbs updated to link to subsection index pages for CLI ref and Tutorials
Breadcrumb styles slightly tweaked to make text smaller
Old:
New: